Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide array implementation details #5358

Merged
merged 2 commits into from
May 10, 2024
Merged

hide array implementation details #5358

merged 2 commits into from
May 10, 2024

Conversation

rbran
Copy link
Contributor

@rbran rbran commented May 3, 2024

This merge and re-split the ArrayProvider traits into CoreArrayProvider and CoreArrayProviderInner, with only the first being public.

@ElykDeer ElykDeer self-assigned this May 10, 2024
Copy link
Member

@ElykDeer ElykDeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Please rebase on top of latest dev and I'll merge it.

@rbran rbran requested a review from ElykDeer May 10, 2024 11:58
@ElykDeer ElykDeer merged commit b2ec4cc into Vector35:dev May 10, 2024
2 checks passed
@rbran rbran deleted the hide-array branch May 10, 2024 16:03
@rbran rbran restored the hide-array branch May 15, 2024 18:07
@rbran rbran deleted the hide-array branch May 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants