Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: change signatures of define_{auto,user}_data_var #5405

Merged
merged 1 commit into from
May 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions rust/src/binaryview.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ use crate::segment::{Segment, SegmentBuilder};
use crate::settings::Settings;
use crate::symbol::{Symbol, SymbolType};
use crate::tags::{Tag, TagType};
use crate::types::{DataVariable, NamedTypeReference, QualifiedName, QualifiedNameAndType, Type};
use crate::types::{
Conf, DataVariable, NamedTypeReference, QualifiedName, QualifiedNameAndType, Type,
};
use crate::Endianness;

use crate::rc::*;
Expand Down Expand Up @@ -574,24 +576,16 @@ pub trait BinaryViewExt: BinaryViewBase {
}
}

fn define_auto_data_var(&self, dv: &DataVariable) {
fn define_auto_data_var<'a, T: Into<Conf<&'a Type>>>(&self, addr: u64, ty: T) {
unsafe {
BNDefineDataVariable(
self.as_ref().handle,
dv.address(),
&mut dv.type_with_confidence().into(),
);
BNDefineDataVariable(self.as_ref().handle, addr, &mut ty.into().into());
}
}

/// You likely would also like to call [`Self::define_user_symbol`] to bind this data variable with a name
fn define_user_data_var(&self, dv: &DataVariable) {
fn define_user_data_var<'a, T: Into<Conf<&'a Type>>>(&self, addr: u64, ty: T) {
unsafe {
BNDefineUserDataVariable(
self.as_ref().handle,
dv.address(),
&mut dv.type_with_confidence().into(),
);
BNDefineUserDataVariable(self.as_ref().handle, addr, &mut ty.into().into());
}
}

Expand Down
Loading