implement rust ExternalLibrary #5683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negasora
requested changes
Jul 3, 2024
| } | ||
|
|
||
| /// Get the ExternalLibrary that this ExternalLocation targets | ||
| pub fn library(&self) -> ExternalLibrary { |
There was a problem hiding this comment.
This should return Option<ExternalLibrary>
| } | ||
|
|
||
| /// Get the file backing this external library | ||
| pub fn backing_file(&self) -> ProjectFile { |
There was a problem hiding this comment.
This should return Option<ProjectFile>
| } | ||
|
|
||
| /// Remove the symbol pointed to by this ExternalLocation. | ||
| pub fn remove_target_symbol(&self) -> bool { |
There was a problem hiding this comment.
This should be removed and set_target_symbol should take an Option<S>
| } | ||
|
|
||
| /// Set the file backing this external library | ||
| pub fn set_backing_file(&self, file: &ProjectFile) { |
There was a problem hiding this comment.
file should be Option<&ProjectFile>
|
Merged in f90f851, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.