Binary view type selection from "Open with Options" #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zznop
force-pushed
the
test_force_load_bv_type
branch
from
4a8b1a8 to
add762c
Compare
zznop
force-pushed
the
test_force_load_bv_type
branch
from
add762c to
f3de187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
IsForceLoadablemethod to theBinaryViewTypeclass. This was done to allow selection of binary view types for raw binary formats. It allows users to select binary views from the "Open with Options" UI regardless of whether or notBinaryViewType->IsValidForDatareturnstrue.IsForceLoadablereturnsfalsefor all existing views, but can be overridden in new views for binary formats that don't contain any header information that can be used to detect compatibility.Related PR: https://github.com/Vector35/binaryninja/pull/811