Add padding parameter to VFSGetBuffer #4581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scudette
added a commit
that referenced
this pull request
Dec 23, 2025
## Describe your changes This PR adds the ability to optionally read from the sparse file instead of the padded file when using `VFSGetBuffer`. - Add `padding` parameter to `api.proto` - Make `in.Padding` default to `true` in `VFSGetBuffer` gRPC handler - Require `padding` to be `true` in order to use ranged reader - Generate `*.pb.go` files using `make_proto.sh` - Add tests to read padded and unpadded sparse file It would be easier to just review the following files - api/api.go - api/events_test.go - api/download.go - api/proto/api.proto The rest of the changes were generated automatically from protobuf. ## Issue ticket number and link #4580 ## Checklist - [x] I have performed a self-review of my code - [x] I have added thorough tests --------- Co-authored-by: Kai <[email protected]> Co-authored-by: Mike Cohen <[email protected]>
scudette
added a commit
that referenced
this pull request
Dec 23, 2025
## Describe your changes This PR adds the ability to optionally read from the sparse file instead of the padded file when using `VFSGetBuffer`. - Add `padding` parameter to `api.proto` - Make `in.Padding` default to `true` in `VFSGetBuffer` gRPC handler - Require `padding` to be `true` in order to use ranged reader - Generate `*.pb.go` files using `make_proto.sh` - Add tests to read padded and unpadded sparse file It would be easier to just review the following files - api/api.go - api/events_test.go - api/download.go - api/proto/api.proto The rest of the changes were generated automatically from protobuf. ## Issue ticket number and link #4580 ## Checklist - [x] I have performed a self-review of my code - [x] I have added thorough tests --------- Co-authored-by: Kai <[email protected]> Co-authored-by: Mike Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds the ability to optionally read from the sparse file instead of the padded file when using
VFSGetBuffer.paddingparameter toapi.protoin.Paddingdefault totrueinVFSGetBuffergRPC handlerpaddingto betruein order to use ranged reader*.pb.gofiles usingmake_proto.shIt would be easier to just review the following files
The rest of the changes were generated automatically from protobuf.
Issue ticket number and link
#4580
Checklist