Skip to content

Fix panic/error in zip accessor handling #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scudette merged 1 commit into from
Dec 16, 2025
Merged

Fix panic/error in zip accessor handling #4589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions accessors/zip/zip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,10 @@ func (self *ZipFileCache) GetChildren(

loop:
for _, cd_cache := range self.lookup {
cd_components := cd_cache.full_path.Components
if len(cd_components) <= len(full_path.Components) {
continue loop
}
// This breaks if the cd component does not have the same
// prefix as required.
for j, component := range full_path.Components {
Expand All @@ -442,12 +446,12 @@ loop:

// The required directory depth we need.
depth := len(full_path.Components)
if len(cd_cache.full_path.Components) <= depth {
if len(cd_components) <= depth {
continue
}

// Get the part of the path that is at the required depth.
member_name := normalizer(cd_cache.full_path.Components[depth])
member_name := normalizer(cd_components[depth])

// Have we seen this before?
old_result, pres := seen[member_name]
Expand Down
Loading