Bugfix: Filestore path types were inferred from the file extension #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However in certain paths in the filestore (e.g. file uploads in collections) the files are always stored with PATH_TYPE_FILESTORE_ANY. This meant that uploaded files with the same extension as internal files were mistaken for different filestore paths. This PR infers the pathspec type from the components list. It carves out directories in the filestore which are untyped. All files stored there will be assigned a PATH_TYPE_FILESTORE_ANY type, regardless of file extension.
scudette
added a commit
that referenced
this pull request
Dec 23, 2025
…4592) However in certain paths in the filestore (e.g. file uploads in collections) the files are always stored with PATH_TYPE_FILESTORE_ANY. This meant that uploaded files with the same extension as internal files were mistaken for different filestore paths. This PR infers the pathspec type from the components list. It carves out directories in the filestore which are untyped. All files stored there will be assigned a PATH_TYPE_FILESTORE_ANY type, regardless of file extension.
scudette
added a commit
that referenced
this pull request
Dec 23, 2025
…4592) However in certain paths in the filestore (e.g. file uploads in collections) the files are always stored with PATH_TYPE_FILESTORE_ANY. This meant that uploaded files with the same extension as internal files were mistaken for different filestore paths. This PR infers the pathspec type from the components list. It carves out directories in the filestore which are untyped. All files stored there will be assigned a PATH_TYPE_FILESTORE_ANY type, regardless of file extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However in certain paths in the filestore (e.g. file uploads in collections) the files are always stored with
PATH_TYPE_FILESTORE_ANY. This meant that uploaded files with the same extension as internal files were mistaken for different filestore paths.
This PR infers the pathspec type from the components list. It carves out directories in the filestore which are untyped. All files stored there will be assigned a PATH_TYPE_FILESTORE_ANY type, regardless of file extension.