Add upload_webdav to collector #4611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the existing artifact upload_webdav to the collector build logic, to line up with the other "cloud targets" (S3, SFTP, SMB ...) as WebDAV.
While testing an issue occurred in the artifact itself, which is also fixed by this PR. Since the velociraptor log file is also always uploaded, a http contentLength mismatch error appeared. The reason was that ongoing writes to the log changed the actual file size since the contentLength was determined.
[INFO] 2026-01-05T11:11:51Z upload_webdav: Put "https://readacted/webdav/Collection-DESKTOP-WK-2026-01-05T11_11_35Z.log": http2: request body larger than specified content lengthThe solution was to just remove the definition of the contentLength and let the lower layers handle it. Tested. Works.