Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

security: CWE-494: Pin S3 template URLs with versionId — VC-53699#1

Open
torresashjiancyber wants to merge 1 commit into
Venafi:mainfrom
torresashjiancyber:VC-53699-logos-fix-c
Open

security: CWE-494: Pin S3 template URLs with versionId — VC-53699#1
torresashjiancyber wants to merge 1 commit into
Venafi:mainfrom
torresashjiancyber:VC-53699-logos-fix-c

Conversation

@torresashjiancyber

Copy link
Copy Markdown

Summary

Addresses CWE-494 (Download of Code Without Integrity Check) by pinning all CloudFormation template S3 URLs with version identifiers and enhancing IAM capability review guidance.

Finding

The workshop documentation directed users to invoke aws cloudformation create-stack with mutable S3 template URLs (no ?versionId= pin) and CAPABILITY_IAM permissions, creating a supply-chain risk: any party able to overwrite those S3 objects could provision arbitrary IAM roles and Lambda code in consumer AWS accounts.

CVSS 8.5 High - CWE-494: Download of Code Without Integrity Check

Remediation

Applied minimal security controls to 7 deployment entry points across documentation:

  1. S3 URL pinning: Appended ?versionId=REPLACE_WITH_PINNED_VERSION_ID to all template URLs:

    • docs/02-one-time-aws-account-setup/README.md (venafi-one-time-setup.yaml)
    • docs/03-tlspc-policy-automation/README.md (tlspc-policy.yaml, 2 refs)
    • docs/04-tlspc-certificate-automation/README.md (tlspc-certificate.yaml)
    • docs/101-cloudformation-from-aws-cli/README.md (3 CLI commands)
  2. IAM review guidance: Replaced "check ✅ the Capabilities checkbox" in one-time setup with explicit instruction to review IAM template content before acknowledging CAPABILITY_IAM.

Note: Placeholder REPLACE_WITH_PINNED_VERSION_ID requires substitution with actual S3 object version IDs before deployment.

Verification

  • Documentation-only repository; no build/test suite applicable
  • All 7 S3 URLs successfully pinned
  • IAM review step enhanced in setup documentation
  • Changes preserve existing deployment workflow structure

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant