Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timeout): use timeout from plugin SDK #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaikanthjay46
Copy link

Description

Adds the ability to specify terraform native timeout config so that it can be overridden. Closes #80

I wrote this code sometime back but was unable to get unit tests running successfully. There is some kind of mock bundle needed I guess.

to match with previous hardcoded configuration
@forevergenin
Copy link

This PR is open and under review for quite sometime. Are there any challenges with getting this merged ?

@forevergenin
Copy link

@tr1ck3r can you help with this PR ?

@luispresuelVenafi
Copy link
Contributor

HI @forevergenin

Thank you for reaching out and @jaikanthjay46 for his contribution, all of these are welcome for our Open Source integrations. @tr1ck3r is no longer an active contributor to our Open Source products. Effectively, you should reach out to our default users set, currently, when a PR is created. That said I'll bring this up with my manger so we can size this work and plan when can this be integrated into a sprint so we can get it merge. There's some QA process we need to get code merge, especially if from external. Thank you for you patience and understanding! :)

@forevergenin
Copy link

forevergenin commented Jul 17, 2023

Thanks for the quick response @luispresuelVenafi ! Appreciate you taking time to set the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Custom Timeouts
3 participants