Fix p12 certificate decryption #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current versions of openssl generate p12 files which are not parsable by x/crypto/pkcs12 with the default flags. Update our pkcs12 library to the one from sslmate. This is already used in resource_venafi_certificate, so it's not a new import. Signed-off-by: Adrian Lai <[email protected]>
aidy
requested review from
rvelaVenafi,
marcos-albornoz,
luispresuelVenafi and
EduardoVV
as code owners
|
Addresses the first part of #151 |
hawksight
pushed a commit
to hawksight/terraform-provider-venafi
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current versions of openssl generate p12 files which are not parsable by x/crypto/pkcs12 with the default flags.
Update our pkcs12 library to the one from sslmate. This is already used in resource_venafi_certificate, so it's not a new import.