Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for custom startup animations #355

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

ading2210
Copy link

@ading2210 ading2210 commented Jan 22, 2024

Based on feedback from #354, I've implemented a way to set a custom image on the splash window. The file is loaded from the user's filesystem, so no copyrighted assets are used.

image

vesktop_custom_splash-2024-01-22_23.45.06.mp4

This fixes issue #352 completely.

@ading2210
Copy link
Author

ading2210 commented Jan 24, 2024

I wouldn't recommend merging this at the moment, since it's currently broken under Windows. It's running into some issue reading the image file, and I haven't been able to do any testing.

@Vendicated Vendicated marked this pull request as draft January 24, 2024 07:11
@ading2210
Copy link
Author

Is anyone else able to test this on Windows? The person I had asked to test it before didn't rebuild the app properly. They rebuilt it today with the latest changes, and it's working now.

@ading2210 ading2210 marked this pull request as ready for review January 28, 2024 22:48
@jacksongoode
Copy link

Works for me 👍 definitely needed!

@Arian04
Copy link

Arian04 commented Mar 12, 2024

is there anything blocking the merging of this that I could help with? If you guys need another tester for this on Windows in addition to the two people above, I could try it out.

@ZirixCZ ZirixCZ mentioned this pull request Mar 13, 2024
@ading2210
Copy link
Author

@Vendicated

Now that all the merge conflicts are fixed (thanks to @sz6084), do you have any suggestions on how this PR can be improved? Considering the demand for this feature, hopefully we can get this merged as soon as possible.

src/main/index.ts Outdated Show resolved Hide resolved
@jmshgs

This comment was marked as spam.

@rklxmok

This comment was marked as spam.

@Covkie
Copy link
Collaborator

Covkie commented Jun 12, 2024

The ability to select multiple and have them picked at random would be nice as well.

@Covkie Covkie mentioned this pull request Jun 18, 2024
13 tasks
@Covkie
Copy link
Collaborator

Covkie commented Jul 26, 2024

Error occurred in handler for 'VCD_SELECT_IMAGE_PATH': Error: ENOENT: no such file or directory, stat '/home/kylie/.config/vesktop/splash'

Seems youre not correctly creating the splash directory

@ading2210
Copy link
Author

@Covkie That error is fixed in the latest commit. It was happening because Vesktop was unconditionally trying to delete and remake the splash directory, even if it didn't exist before. Obviously this would have caused an error when it tried to remove a nonexistent directory, but it didn't happen in my previous testing because that directory was already there.

@Vencord Vencord deleted a comment from stankovictab Aug 7, 2024
@LethalManBoob

This comment was marked as off-topic.

@MMachado05
Copy link

MMachado05 commented Sep 25, 2024

Do you know if the way this has been implemented will support APNGs? They tend to be of better quality and of smaller filesize. Perhaps even AVIF or WebP. 😁

@ading2210
Copy link
Author

ading2210 commented Sep 25, 2024

@MMachado05 An <img> tag is used to load the animation, so APNG, AVIF, and WebP images should all work already.

@fxzzi
Copy link

fxzzi commented Oct 13, 2024

I've gone ahead and done some testing with this PR on linux. From what I can see, everything seems to work perfectly on my end. Imo, this is ready for merging but I'm not a maintainer soooo

@lewisakura
Copy link
Member

Has this been Flatpak tested?

@jmshgs

This comment has been minimized.

@lewisakura

This comment was marked as off-topic.

@ADecametre
Copy link

Amazing, thank you. 🙏

@eeelbrens
Copy link

so?

@kxtzownsu

This comment was marked as spam.

@SomeRandomCpu

This comment was marked as spam.

@lewisakura
Copy link
Member

Has this been Flatpak tested?

@ading2210 I still need an update on this. This isn't mergeable if it doesn't work in Flatpak.

@chrrybmb64

This comment was marked as off-topic.

@Vencord Vencord locked and limited conversation to collaborators Dec 27, 2024
@Vencord Vencord deleted a comment from sz6084 Dec 27, 2024
@Vencord Vencord deleted a comment from tomma365 Dec 27, 2024
@Vencord Vencord deleted a comment from lothar-cell Dec 27, 2024
@Vencord Vencord deleted a comment from lothar-cell Dec 27, 2024
@Vencord Vencord deleted a comment from LethalManBoob Dec 27, 2024
@Vencord Vencord deleted a comment from LethalManBoob Dec 27, 2024
@Vencord Vencord deleted a comment from LethalManBoob Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.