fixed Issue #17 support URL suffix. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support suffix url fixed bug '/' ending VSF URL.
add php 7.4 and magento 2.4
Tjitse-E
requested changes
Aug 26, 2021
| @@ -57,14 +57,16 @@ public function __construct( | |||
| ProductCollection $productCollection, | |||
| DirectoryList $directoryList, | |||
| SitemapFactory $sitemapFactory, | |||
| \Magento\Framework\App\Config\ScopeConfigInterface $appConfigScopeConfig, | |||
There was a problem hiding this comment.
on my development environment (Magento 2.4) this code is worked.
There was a problem hiding this comment.
Can you still import it so the coding style matches the original?
| @@ -87,7 +89,7 @@ public function execute() : void | |||
| $this->addProductsToSitemap(); | |||
|
|
|||
| // Generate | |||
| $this->sitemap->createSitemapIndex($domain, 'Today'); | |||
| $this->sitemap->createSitemapIndex($domain . "/", 'Today'); | |||
There was a problem hiding this comment.
Why is it needed to add a "/" here?
There was a problem hiding this comment.
as current will generate 2 files.
- when VSF URL in domain name end with '/' sitemap-index.xml will corrected but sitemap.xml will have '//'.
- when VSF URL domain name without end with '/' sitemap-index.xml will incorrect but site sitemap.xml will corrected.
There was a problem hiding this comment.
Aha, so in that case it is better that we just force the user to enter the url with a '/' suffix. We could do this https://github.com/Vendic/magento2-vuestorefront-xmlsitemap/blob/master/etc/adminhtml/system.xml#L13-L16 using the <validate> tag.
Tjitse-E
requested changes
Aug 26, 2021
| @@ -57,14 +57,16 @@ public function __construct( | |||
| ProductCollection $productCollection, | |||
| DirectoryList $directoryList, | |||
| SitemapFactory $sitemapFactory, | |||
| \Magento\Framework\App\Config\ScopeConfigInterface $appConfigScopeConfig, | |||
There was a problem hiding this comment.
Can you still import it so the coding style matches the original?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue #17
this used on my environment is VSF 1.9 + Magento 2.4