Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT ServiceLoader implementation for J2CL+Closure #245

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

DRAFT ServiceLoader implementation for J2CL+Closure #245

wants to merge 8 commits into from

Commits on Nov 23, 2023

  1. Current iteration of test and compiler pass 

    Note that the pass still runs too early, but we can't easily run it
earlier because we're dependent on inlineFunction rewriting params to
the lookup/register calls.
    @niloc132
    niloc132 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c89a94d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Simplify the pass, run more often, doesn't help

    @niloc132
    niloc132 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    27f1829 View commit details
    Browse the repository at this point in the history

  2. Try to simplify the JS to get the compiler to understand, failure

    @niloc132
    niloc132 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    b6746ee View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. New approach, partial success

    @niloc132
    niloc132 committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    df92b61 View commit details
    Browse the repository at this point in the history

  2. Correct extra invocation, check for null - fully working

    @niloc132
    niloc132 committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ff24edd View commit details
    Browse the repository at this point in the history

  3. Correct compiler initialization, ensuring defines are set properly

    @niloc132
    niloc132 committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7408030 View commit details
    Browse the repository at this point in the history

  4. Add validation for output of integration test

    @niloc132
    niloc132 committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c6665d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Somewhat hacky fix to still build other optimization levels

    @niloc132
    niloc132 committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    306a061 View commit details
    Browse the repository at this point in the history