Skip to content

chore: bump very_good_analysis to v10.1.0 #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ricardodalarme wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: bump very_good_analysis to v10.1.0 #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bricks/test_optimizer/hooks/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.0
test: ^1.25.0
very_good_analysis: ^10.0.0
very_good_analysis: ^10.1.0-rc.2
2 changes: 1 addition & 1 deletion e2e/helpers/command_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void Function() _overridePrint(void Function(List<String>) fn) {
return () {
final printLogs = <String>[];
final spec = ZoneSpecification(
print: (_, _, _, String msg) {
print: (_, _, _, msg) {
printLogs.add(msg);
},
);
Expand Down
2 changes: 1 addition & 1 deletion e2e/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ dev_dependencies:
pub_updater: ^0.5.0
test: ^1.25.0
universal_io: ^2.0.4
very_good_analysis: ^10.0.0
very_good_analysis: ^10.1.0-rc.2
very_good_cli:
path: ../
2 changes: 1 addition & 1 deletion lib/src/cli/templates/test_optimizer_bundle.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ dev_dependencies:
build_verify: ^3.1.0
mocktail: ^1.0.4
test: ^1.25.8
very_good_analysis: ^10.0.0
very_good_analysis: ^10.1.0-rc.2

executables:
very_good:
2 changes: 1 addition & 1 deletion test/helpers/command_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void Function() _overridePrint(void Function(List<String>) fn) {
return () {
final printLogs = <String>[];
final spec = ZoneSpecification(
print: (_, _, _, String msg) {
print: (_, _, _, msg) {
printLogs.add(msg);
},
);
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/dart/commands/dart_test_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ void main() {
dartTest = _MockDartTestCommand();
testCommand = DartTestCommand(
logger: logger,
dartInstalled: ({required Logger logger}) async => isFlutterInstalled,
dartInstalled: ({required logger}) async => isFlutterInstalled,
dartTest: dartTest.call,
)..argResultOverrides = argResults;
when(
Expand Down
12 changes: 6 additions & 6 deletions test/src/commands/packages/commands/check/commands/licenses_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1142,7 +1142,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1191,7 +1191,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1315,7 +1315,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down Expand Up @@ -1364,7 +1364,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down Expand Up @@ -1415,7 +1415,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down
3 changes: 1 addition & 2 deletions test/src/commands/test/test_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ void main() {
flutterTest = _MockFlutterTestCommand();
testCommand = TestCommand(
logger: logger,
flutterInstalled: ({required Logger logger}) async =>
isFlutterInstalled,
flutterInstalled: ({required logger}) async => isFlutterInstalled,
Copy link
Member

@marcossevilla marcossevilla Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an interesting case, I wonder if it would have issues determining types when there are name params

flutterTest: flutterTest.call,
)..argResultOverrides = argResults;
when(
Expand Down
2 changes: 1 addition & 1 deletion tool/spdx_license/hooks/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.3
test: ">=1.25.2 <1.27.0"
very_good_analysis: ^10.0.0
very_good_analysis: ^10.1.0-rc.2
2 changes: 1 addition & 1 deletion tool/spdx_license/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ environment:

dev_dependencies:
test: ^1.25.2
very_good_analysis: ^10.0.0
very_good_analysis: ^10.1.0-rc.2