Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor data loading out of app.py #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor data loading out of app.py #23

wants to merge 2 commits into from
+480 −424

Conversation

jonulak
Copy link
Contributor

@jonulak jonulak commented Nov 22, 2024 •
edited
Loading

Refactor data loading logic out of app.py into data/data_loader.py

  • All data loading logic moved to data_loader.py
  • app.py imports and uses functions from data_loader
  • All existing tests pass
    • Refactored tests from tests/test_streamlit_app.py to data/tests/test_data_loader.py
  • No changes to current data loading behavior

Resolves #20

@jeromehardaway jeromehardaway added the bug Something isn't working label Nov 22, 2024
@jeromehardaway jeromehardaway assigned jonulak and unassigned Sfayson1 Nov 22, 2024
@jonulak jonulak marked this pull request as ready for review November 22, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromehardaway jeromehardaway Awaiting requested review from jeromehardaway

@Sfayson1 Sfayson1 Awaiting requested review from Sfayson1

At least 1 approving review is required to merge this pull request.

Assignees

@jonulak jonulak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate job code loading from app.py
3 participants
@jonulak @jeromehardaway @Sfayson1