Skip to content

fix: BarWidget QML errors preventing plugins from loading in Noctalia #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VictorGSchneider merged 1 commit into from
May 29, 2026
Merged

fix: BarWidget QML errors preventing plugins from loading in Noctalia #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions theme/noctalia-plugins/stoa-doctor-pill/BarWidget.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,18 @@ import qs.Widgets
Item {
id: root

property var pluginApi: null
property var pluginApi: null
property ShellScreen screen
property string widgetId: ""
property string section: ""
property int sectionWidgetIndex: -1

property string tooltipText: issues < 0 ? "Doctor log not found — run stoa-doctor"
: issues > 0
? issues + " issue" + (issues > 1 ? "s" : "") +
(warnings > 0 ? " · " + warnings + " warning" + (warnings > 1 ? "s" : "") : "")
: warnings > 0 ? warnings + " warning" + (warnings > 1 ? "s" : "")
: "All systems nominal"

implicitWidth: pill.implicitWidth + Style.marginM * 2
implicitHeight: parent ? parent.height : 32
Expand Down Expand Up @@ -67,19 +78,6 @@ Item {
}
}

NToolTip {
target: root
text: root.issues < 0 ? "Doctor log not found — run stoa-doctor"
: root.issues > 0
? root.issues + " issue" + (root.issues > 1 ? "s" : "") +
(root.warnings > 0
? " · " + root.warnings + " warning" + (root.warnings > 1 ? "s" : "")
: "")
: root.warnings > 0
? root.warnings + " warning" + (root.warnings > 1 ? "s" : "")
: "All systems nominal"
}

// ── Click → popup menu ──
MouseArea {
anchors.fill: parent
Expand Down
23 changes: 12 additions & 11 deletions theme/noctalia-plugins/stoa-drive-pill/BarWidget.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,18 @@ import qs.Widgets
Item {
id: root

property var pluginApi: null
property var pluginApi: null
property ShellScreen screen
property string widgetId: ""
property string section: ""
property int sectionWidgetIndex: -1

property string tooltipText: !_available ? "rclone not installed"
: total === 0 ? "No cloud drives configured"
: mounted === total
? "All drives mounted (" + total + "/" + total + ")"
: mounted > 0 ? mounted + " / " + total + " drives mounted"
: "No drives mounted — click to manage"

visible: _available
implicitWidth: visible ? pill.implicitWidth + Style.marginM * 2 : 0
Expand Down Expand Up @@ -68,16 +79,6 @@ Item {
}
}

NToolTip {
target: root
text: !root._available ? "rclone not installed"
: root.total === 0 ? "No cloud drives configured"
: root.mounted === root.total
? "All drives mounted (" + root.total + "/" + root.total + ")"
: root.mounted > 0 ? root.mounted + " / " + root.total + " drives mounted"
: "No drives mounted — click to manage"
}

// ── Click → popup ──
MouseArea {
anchors.fill: parent
Expand Down
Loading