fix: correct NPopupContextMenu API (onTriggered + openAtItem) - #122
Merged
Conversation
NPopupContextMenu emits signal triggered(string action, var item), not action. Also replace PanelService.showContextMenu() with the component's own openAtItem(root, screen) method, and remove the unused qs.Services.UI import. https://claude.ai/code/session_01JH7MsJFvce1eEde8DJiCfe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Ambos os
BarWidget.qmlfalhavam ao carregar com:NPopupContextMenuemitesignal triggered(string action, var item)— nãoaction. E o menu abre viaopenAtItem(item, screen), não viaPanelService.showContextMenu().Mudanças
onAction: function(action)→onTriggered: function(action, item)em ambos os pluginsPanelService.showContextMenu(contextMenu, root, screen)→contextMenu.openAtItem(root, screen)import qs.Services.UI(não mais necessário)Como testar
Após
git pulle reiniciar o Noctalia, os pills do doctor e drive devem aparecer na bar. Botão direito deve abrir o menu de contexto.https://claude.ai/code/session_01JH7MsJFvce1eEde8DJiCfe
Generated by Claude Code