fix(doctor): correctly detect running Noctalia Shell - #135
Merged
Conversation
PR #127 introduced a Noctalia check that never matched the real process: stoa-bar launches `quickshell -c noctalia-shell`, but the pgrep patterns looked for argv[0] == 'noctalia-shell' / 'noctalia' or cmdline containing 'qs -c noctalia' (note: 'qs', not 'quickshell'). Result: doctor printed "Noctalia Shell is not running — notifications won't show" on every boot even though it was up. Collapse to a single `pgrep -f 'noctalia-shell'` — substring match over the cmdline catches all three launch shapes: quickshell -c noctalia-shell qs -c noctalia-shell noctalia-shell (AUR wrapper)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug do PR #127. O check do Noctalia que adicionei no
stoa-doctornunca matchava o processo real, então toda hora aparecia[WARN] Noctalia Shell is not running — notifications won't showmesmo com o Noctalia em pé.O
stoa-barsobe o shell comoquickshell -c noctalia-shell. Meus padrões pgrep originais procuravam por:pgrep -fx 'noctalia-shell'— exige que o argv[0] seja literalmentenoctalia-shell. Não bate, o argv[0] équickshell.pgrep -f 'qs -c noctalia'— usariaqs, mas ostoa-barchamaquickshell. Também não bate.pgrep -fx 'noctalia'— só matchava se o argv[0] fossenoctalia. Idem, não bate.Substitui tudo por um único
pgrep -f 'noctalia-shell'(substring no cmdline inteiro), que pega todas as três formas de lançamento:Test plan
stoa-doctor→ linha[OK] Noctalia Shell is running (notifications).killall quickshell; stoa-doctor→ linha[WARN] Noctalia Shell is not running ….Generated by Claude Code