api: add disableAutomountServiceAccountToken field #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting improves application security and simplifies it's configuration. Security rules for cloud provides may forbid implicit serviceAccount token mounting into the Pod. Such as AKS see the following example: VictoriaMetrics/helm-charts#2006 (comment) This commit allows to disable default behavior by changing `Statefulset` and `Deployment` `spec.template.spec.automountServiceAccountToken` setting. It prevents token volume mount by controller-manager. In addition, operator explicitly adds Kubernetes API access to the following objects: * VMAgent vmagent and config-reloader containers. * VMAuth config-reloader and init-config containers - if useVMConfigReloader: true is set. * VMAlertmanager config-reloader and init-config - if useVMConfigReloader: true is set. Operator adds volume with name `kube-api-access` and volumeMount with path `/var/run/secrets/kubernetes.io/serviceaccount`. Related issue: #1255
Signed-off-by: f41gh7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting improves application security and simplifies it's
configuration.
Security rules for cloud provides may forbid implicit serviceAccount
token mounting into the Pod. Such as AKS see the following example: VictoriaMetrics/helm-charts#2006 (comment)
This commit allows to disable default behavior by changing
StatefulsetandDeploymentspec.template.spec.automountServiceAccountTokensetting. It prevents token volume mount by controller-manager.In addition, operator explicitly adds Kubernetes API access to the
following objects:
Operator adds volume with name
kube-api-accessand volumeMount withpath
/var/run/secrets/kubernetes.io/serviceaccount.Related issue:
#1255