update

lib/ffmpeg/transcoder.rb

@@ -76,7 +76,6 @@ def run(&)
     end
 
     def encoding_succeeded?
-      # failing test
       @errors << "no output file created" and return false unless File.exist?(@output_file)
       @errors << "encoded file is invalid" and return false unless encoded.valid?
       true
@@ -207,13 +206,8 @@ def transcode_movie
           raise Error, "Process hung. Full output: #{@output}"
         end
       end
-      begin
-        FileUtils.cp(temp_output_file, @output_file)
-      rescue Errno::ENOENT
-        raise FFMPEG::Error, "no output file created"
-      ensure
-        FileUtils.rm_rf(temp_output_file, secure: true)
-      end
+      FileUtils.cp(temp_output_file, @output_file)
+      FileUtils.rm_rf(temp_output_file, secure: true)
     end
 
     def validate_output_file(&block)

spec/ffmpeg/transcoder_spec.rb

@@ -215,9 +215,7 @@ module FFMPEG
 
         pending "should not crash on ISO-8859-1 characters (dont know how to spec this)"
 
-        # failing test
         it "should fail when given an invalid movie" do
-          expect(FFMPEG.logger).to receive(:error).at_least(:once)
           movie = Movie.new(__FILE__)
           transcoder = Transcoder.new(movie, "#{tmp_path}/fail.flv")
           expect { transcoder.run }.to raise_error(FFMPEG::Error, /no output file created/)
@@ -285,7 +283,6 @@ module FFMPEG
             FFMPEG.ffmpeg_binary = "#{fixture_path}/bin/ffmpeg-audio-only"
           end
 
-          # failing test
           it "should not fail when the timeout is exceeded" do
             transcoder = Transcoder.new(movie, "#{tmp_path}/timeout.mp4")
             # Would expect to raise (FFMPEG::Error, /Process hung/) before this