Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewed and edited #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reviewed and edited #1

wants to merge 1 commit into from

Conversation

mikedd96
Copy link

empty repositories left (_base.scss)
make loading icon smaller to match clients ideal website, as well as resize logo in desktop, space above logo on initial desktop view to large and 600px view the logo is pushed down past screen view
footer wrong size
create span around words in a line that will have their own styles, and use text transform: uppercase instead of capitalizing all letters in the html text ( index.html line 48)fixed
change title to your sites title (index.html line 8)fixed
remove commented out code in javascript (script.js line 54, line 73 to 77)fixed

@@ -45,7 +45,7 @@ <h3>Choose A Selection</h3>
</ul>
</section>
<footer>
<h4>&copy;Copyright 2019 INSTANEWS</h4>
<h4>&copy;Copyright 2019 I<span class="capital">instanews</span></h4>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you need to remove the I from before the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants