vine: add Index traits and syntax
#499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricozb
force-pushed
the
enricozb/index
branch
2 times, most recently
from
4491829 to
910b72d
Compare
tjjfvi
reviewed
Jan 27, 2026
vine/src/features/index.rs
Outdated
Comment on lines
31
to
38
| let expr_ty = self.types.new_var(span); | ||
| let expr = self.resolve_expr_type(expr, expr_ty); | ||
| let index_ty = self.types.new_var(span); | ||
| let index = self.resolve_expr_type(index, index_ty); |
Member
There was a problem hiding this comment.
Suggested change
| let expr_ty = self.types.new_var(span); | |
| let expr = self.resolve_expr_type(expr, expr_ty); | |
| let index_ty = self.types.new_var(span); | |
| let index = self.resolve_expr_type(index, index_ty); | |
| let expr = self.resolve_expr(expr); | |
| let index = self.resolve_expr(index); |
and s/(expr|index)_ty/\1.ty/
enricozb
force-pushed
the
enricozb/index
branch
2 times, most recently
from
6bc6565 to
7c57e8b
Compare
enricozb
force-pushed
the
enricozb/index
branch
from
7c57e8b to
46b3eb4
Compare
tjjfvi
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #443