Sourcery Starbot ⭐ refactored Vinyzu/DiscordGenerator #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
May 18, 2023
Comment on lines
-62
to
+68
| output += self.token + ":" | ||
| output += f"{self.token}:" | ||
| if "email" in item and self.email: | ||
| output += self.email + ":" | ||
| output += f"{self.email}:" | ||
| if "pass" in item: | ||
| output += self.browser.faker.password + ":" | ||
| output += f"{self.browser.faker.password}:" | ||
| if "proxy" in item and self.browser.proxy: | ||
| output += self.browser.proxy + ":" | ||
| output += f"{self.browser.proxy}:" |
There was a problem hiding this comment.
Function Generator.log_output refactored with the following changes:
- Use f-string instead of string concatenation [×4] (
use-fstring-for-concatenation)
| @@ -102,7 +102,6 @@ async def generate_unclaimed(self): | |||
| await self.page.click("[class *= 'checkbox']", timeout=10000) | |||
| except Exception as e: | |||
| self.logger.debug("No TOS Checkbox was detected") | |||
| pass | |||
There was a problem hiding this comment.
Function Generator.generate_unclaimed refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
This removes the following comments ( why? ):
# Catch Exceptions and save output anyways
| @@ -213,7 +211,6 @@ async def generate_token(self): | |||
| await tos_box.click() | |||
| except Exception as e: | |||
| self.logger.debug("No TOS Checkbox was detected") | |||
| pass | |||
There was a problem hiding this comment.
Function Generator.generate_token refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
This removes the following comments ( why? ):
# Catch Exceptions and save output anyways
Comment on lines
-332
to
+328
| email = True if email == "1" else False | ||
| email = email == "1" |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Simplify boolean if expression [×2] (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool [×2] (
remove-unnecessary-cast)
| headers = { | ||
| return { |
There was a problem hiding this comment.
Function Discord.get_headers refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-19
to
+32
| def makeHTTPRequest(endpoint): | ||
| def makeHTTPRequest(self): | ||
| headers = { | ||
| "User-Agent": "TempMailPythonAPI/1.0", | ||
| "Accept": "application/json" | ||
| } | ||
| try: | ||
| connection = httpx.get(BASE_URL + endpoint, headers=headers) | ||
| connection = httpx.get(BASE_URL + self, headers=headers) | ||
| if connection.status_code >= 400: | ||
| raise Exception("HTTP Error: " + str(connection.status_code)) | ||
| raise Exception(f"HTTP Error: {str(connection.status_code)}") | ||
| except Exception as e: | ||
| print(e) | ||
| return None | ||
|
|
||
| response = connection.text | ||
|
|
||
| return response | ||
| return connection.text |
There was a problem hiding this comment.
Function TempMail.makeHTTPRequest refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-41
to
+44
| def generateInbox(rush=False): | ||
| def generateInbox(self): | ||
| try: | ||
| random_domain = random.choice(DOMAINS) | ||
| s = TempMail.makeHTTPRequest(f"/generate/{random_domain}") | ||
| except: | ||
| print("Website responded with: " + s) | ||
| print(f"Website responded with: {s}") |
There was a problem hiding this comment.
Function TempMail.generateInbox refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-54
to
+53
| def getEmails(inbox): | ||
| s = TempMail.makeHTTPRequest("/auth/" + inbox.token) | ||
| def getEmails(self): | ||
| s = TempMail.makeHTTPRequest(f"/auth/{self.token}") |
There was a problem hiding this comment.
Function TempMail.getEmails refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Use x is None rather than x == None (
none-compare) - Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-109
to
+113
| return ("Email (sender={}, recipient={}, subject={}, body={}, html={}, date={} )" | ||
| .format(self.sender, self.recipient, self.subject, self.body, self.html, self.date)) | ||
| return f"Email (sender={self.sender}, recipient={self.recipient}, subject={self.subject}, body={self.body}, html={self.html}, date={self.date} )" |
There was a problem hiding this comment.
Function Email.__repr__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
modules/tempmail.py
Outdated
Comment on lines
129
to
130
| return ("Inbox (address={}, token={} )" | ||
| .format(self.address, self.token)) No newline at end of file | ||
| return f"Inbox (address={self.address}, token={self.token} )" |
There was a problem hiding this comment.
Function Inbox.__repr__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: