fix: fix react component update

VisActor · Jul 12, 2024 · a346932 · a346932
1 parent 81087cb
commit a346932
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 10 deletions.
diff --git a/packages/vtable/src/components/react/react-custom-layout.ts b/packages/vtable/src/components/react/react-custom-layout.ts
@@ -216,16 +216,16 @@ function getUpdateCustomCellRangeInListTable(componentId: string, table: BaseTab
     }
   }
 
-  // return {
-  //   start: {
-  //     col: 0,
-  //     row: 0
-  //   },
-  //   end: {
-  //     col: table.colCount - 1,
-  //     row: table.rowCount - 1
-  //   }
-  // };
+  return {
+    start: {
+      col: 0,
+      row: 0
+    },
+    end: {
+      col: table.colCount - 1,
+      row: table.rowCount - 1
+    }
+  };
 }
 
 function getUpdateCustomCellRangeInPivotTable(

diff --git a/packages/vtable/src/scenegraph/component/custom.ts b/packages/vtable/src/scenegraph/component/custom.ts
@@ -523,6 +523,9 @@ function onBeforeAttributeUpdate(val: Record<string, any>, attribute: any) {
     return;
   }
   const cellGroup = getTargetCell(graphic) as Group;
+  if (!cellGroup || cellGroup.stage) {
+    return;
+  }
   const table = ((cellGroup as any).stage as any).table as BaseTableAPI;
   graphic.skipAttributeUpdate = true;
   const { mergeStartCol, mergeEndCol, mergeStartRow, mergeEndRow } = cellGroup;

diff --git a/packages/vtable/src/scenegraph/layout/update-height.ts b/packages/vtable/src/scenegraph/layout/update-height.ts
@@ -190,6 +190,10 @@ export function updateCellHeight(
       (cell.getChildByName(CUSTOM_CONTAINER_NAME) as Group) ||
       (cell.getChildByName(CUSTOM_MERGE_CONTAINER_NAME) as Group);
     if (customContainer) {
+      if (scene.table.reactCustomLayout) {
+        scene.table.reactCustomLayout.removeCustomCell(col, row);
+      }
+
       let customElementsGroup;
       customContainer.removeAllChild();
       cell.removeChild(customContainer);

diff --git a/packages/vtable/src/scenegraph/layout/update-width.ts b/packages/vtable/src/scenegraph/layout/update-width.ts
@@ -350,6 +350,9 @@ function updateCellWidth(
       (cell.getChildByName(CUSTOM_CONTAINER_NAME) as Group) ||
       (cell.getChildByName(CUSTOM_MERGE_CONTAINER_NAME) as Group);
     if (customContainer) {
+      if (scene.table.reactCustomLayout) {
+        scene.table.reactCustomLayout.removeCustomCell(col, row);
+      }
       let customElementsGroup;
       customContainer.removeAllChild();
       cell.removeChild(customContainer);