fix: axis size align with vrender-component #1784

VisActor · May 24, 2024 · e772cfb · e772cfb
1 parent 80c1976
commit e772cfb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/common/changes/@visactor/vtable/fix-axis-size_2024-05-24-07-49.json b/common/changes/@visactor/vtable/fix-axis-size_2024-05-24-07-49.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vtable",
+      "comment": "fix: axis size align with vrender-component #1784",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vtable"
+}
diff --git a/packages/vtable/src/components/axis/get-axis-component-size.ts b/packages/vtable/src/components/axis/get-axis-component-size.ts
@@ -1,4 +1,4 @@
-import { isArray, merge } from '@visactor/vutils';
+import { isArray, isString, merge } from '@visactor/vutils';
 import type { BaseTableAPI } from '../../ts-types/base-table';
 import type { ICellAxisOption } from '../../ts-types/component/axis';
 import { DEFAULT_TEXT_FONT_FAMILY, DEFAULT_TEXT_FONT_SIZE, commonAxis } from './get-axis-attributes';
@@ -69,7 +69,8 @@ export function computeAxisComponentWidth(config: ICellAxisOption, table: BaseTa
 
   // title
   let titleWidth = 0;
-  if (attribute.title.visible && attribute.title.text) {
+  // align with vrender-component, use isString()
+  if (attribute.title.visible && isString(attribute.title.text)) {
     const { width, height } = table.measureText(attribute.title.text, {
       fontSize: attribute.title?.style?.fontSize ?? DEFAULT_TEXT_FONT_SIZE,
       fontWeight: attribute.title?.style?.fontWeight ?? 'normal',