Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard can select disable cell error #1328 #2085

Conversation

zhao-heng-sheng
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

fix #1328

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@fangsmile
Copy link
Contributor

@zhao-heng-sheng 这个pr是完成状态了吗?

@fangsmile fangsmile self-requested a review July 15, 2024 06:15
@zhao-heng-sheng
Copy link
Contributor Author

@zhao-heng-sheng 这个pr是完成状态了吗?@zhao-heng-sheng 这个pr是完成状态了吗?

是的,在方向键和tab键选中单元格前阻止了一下。
全选没有处理,因为我看鼠标多选的时候,是能选择到不支持选中的单元格的,不知道这个符不符合预期,您看下这个需不需要处理,如果需要的话,我再调整

@fangsmile fangsmile changed the base branch from develop to 1328-feature-keyboardToSelectDisableCell July 17, 2024 02:18
@fangsmile fangsmile merged commit 00af203 into VisActor:1328-feature-keyboardToSelectDisableCell Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 表头设置不支持选中后,是否应该不能通过键盘的快捷键选中
2 participants