Skip to content

Fix/column dimension null empty distinction #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fangsmile wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix/column dimension null empty distinction #4897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0adedf2
fix: distinguish null and empty string values in column dimensions
Jan 4, 2026
2176094
docs: update changlog of rush
Jan 4, 2026
5a49f2a
Merge pull request #4889 from Aurora-GSW/fix/column-dimension-null-em…
fangsmile Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...hanges/@visactor/vtable/fix-column-dimension-null-empty-distinction_2026-01-04-11-03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: distinguish null and empty string values in column dimensions\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "[email protected]"
}
7 changes: 6 additions & 1 deletion packages/vtable/src/layout/pivot-header-layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2349,7 +2349,12 @@ export class PivotHeaderLayoutMap implements LayoutMapAPI {
} = {};
colHeaderPath.dimensionKey = colHeader.dimensionKey;
colHeaderPath.indicatorKey = colHeader.indicatorKey;
colHeaderPath.value = colHeader.value ?? this.getIndicatorInfoByIndicatorKey(colHeader.indicatorKey)?.title ?? '';
// 如果value为null且没有indicatorKey时保持value为null（区分null和空字符串，防止单元格数据匹配不对）
colHeaderPath.value =
colHeader.value ??
(colHeader.indicatorKey
? this.getIndicatorInfoByIndicatorKey(colHeader.indicatorKey)?.title ?? ''
: colHeader.value);
colHeaderPath.virtual = colHeader.virtual;
colHeaderPath.role = colHeader.role;
headerPaths.colHeaderPaths!.push(colHeaderPath);
Expand Down
Loading