Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<TC> Add support for libmath #295

Merged
merged 1 commit into from
Jul 3, 2024
Merged

<TC> Add support for libmath #295

merged 1 commit into from
Jul 3, 2024

Conversation

akashkollipara
Copy link
Member

  • Added support for archiving library in library
  • Added support for Toolchain provided libmath
  • Added custom header for math functions
  • Updated compiler macros to export c prototypes
  • Removed redundant functions from libnmath

Issue: #294

@akashkollipara
<TC> Add support for libmath
d2ba34a 
- Added support for archiving library in library
- Added support for Toolchain provided libmath
- Added custom header for math functions
- Updated compiler macros to export c prototypes
- Removed redundant functions from libnmath

Issue: #294
@akashkollipara akashkollipara added enhancement Upgrading feature or request critical update This is a critical update cyancore framework Cyancore framework feature request FR Add new feature or request labels Jul 3, 2024
@akashkollipara akashkollipara added this to the Carbon milestone Jul 3, 2024
@akashkollipara akashkollipara requested a review from ishnajain July 3, 2024 17:40
@akashkollipara akashkollipara self-assigned this Jul 3, 2024
@akashkollipara akashkollipara requested a review from a team as a code owner July 3, 2024 17:40
ishnajain
ishnajain approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@ishnajain ishnajain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishnajain ishnajain enabled auto-merge July 3, 2024 17:57
@akashkollipara akashkollipara disabled auto-merge July 3, 2024 18:28
@akashkollipara akashkollipara merged commit d1f6cec into development Jul 3, 2024
2 checks passed
@akashkollipara akashkollipara deleted the feature/akashkollipara/294-libmath branch July 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishnajain ishnajain ishnajain approved these changes

Assignees

@akashkollipara akashkollipara

Labels
critical update This is a critical update cyancore framework Cyancore framework feature request enhancement Upgrading feature or request FR Add new feature or request
Projects
None yet
Milestone
Carbon
Development

Successfully merging this pull request may close these issues.
2 participants
@akashkollipara @ishnajain