Skip to content

[Feature request] Ability to set the baseline branch name #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
groinder opened this issue Feb 21, 2025 · 2 comments · May be fixed by Visual-Regression-Tracker/backend#330
Open

[Feature request] Ability to set the baseline branch name #455

groinder opened this issue Feb 21, 2025 · 2 comments · May be fixed by Visual-Regression-Tracker/backend#330
Assignees
@groinder

Comments

@groinder
Copy link

groinder commented Feb 21, 2025 •
edited
Loading

I've seen an option in the config called baselineBranchName, however it doesn't seem to do anything. I need to have the possibility to select a baseline branch from the agent config to match screenshots in parallel releases.

The scenario for us as follows:

  • Active development with changes for the next release is done in the develop branch - we have this set as a project default branch.
  • Active development for the soon-to-be-published release is done on a dedicated branch for that release.
  • Some changes go into both branches, but breaking changes go to the develop branch, which results in very differently looking app that the one for the closest release.
  • The extra case is that we need to support updates to the previous releases - once the "soon-to-be-published release" is done, it may receive updates with critical fixes.

Currently, there is no possibility to select which branch should be treated as a baseline for the image comparison - it always happens against the default project branch.

There is also a need to keep the variations for chosen branches, an extra project variable should solve that.
This was referenced Feb 24, 2025
Open
Open
@groinder groinder self-assigned this Feb 25, 2025
@pashidlos
Copy link
Member

@groinder so the problem is that you have multiple branches that act like main branch?
for me it sounds like creating separate project for each of them should work as it will set baseline separately
so you could retain all the history as with main branch and remove those projects when branch is merged to develop
will it work in your case?

@groinder
Copy link
Author

groinder commented Mar 3, 2025 •
edited
Loading

@pashidlos

so the problem is that you have multiple branches that act like main branch?

Yes.

What you suggested could work, but it will be cumbersome to manage.

  1. With multiple projects, there is no easy way to merge one branch into the other - when I need to branch-off a release from the main branch then I want to copy the baselines from the main branch to that branch - within the same project I can use merge feature for that.
  2. The release branch will never be merged back to the main branch, it will live for a year or so, until a few new releases roll out, but I need to keep several release branches in parallel - in case they need to be patched. This is the reason why I introduced the protectedBranch to the project settings, so that a RegExp can be used to keep any pattern of branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groinder groinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#455): handle baselineBranchName Visual-Regression-Tracker/backend
2 participants
@pashidlos @groinder