feat(#455): handle baselineBranchName #330
Conversation
| const mainBranch = createTestRequestDto.sourceBranch ?? project.mainBranchName; | ||
| const baselineBranch = createTestRequestDto.baselineBranchName ?? project.mainBranchName; |
There was a problem hiding this comment.
I noticed that sourceBranch was never used, so I replaced it with baselineBranchName to match existing parameter since that can already be set on the config and is send by the sdk-js if present.
There was a problem hiding this comment.
I guess it was used before to make manual test runs with comparison within branches not base on main branch
please, update docs on this method
|
@pashidlos I think this is now ready, please take a look. |
| @@ -41,6 +41,7 @@ model Project { | |||
| builds Build[] | |||
| TestRun TestRun[] | |||
| testVariations TestVariation[] | |||
| protectedBranch String? | |||
There was a problem hiding this comment.
not sure I completely understand the purpose of this filtering
could we move this change to separate PR?
There was a problem hiding this comment.
Please see my comment here Visual-Regression-Tracker/Visual-Regression-Tracker#455 (comment).
Closes Visual-Regression-Tracker/Visual-Regression-Tracker#455
There is also correlated frontend MR Visual-Regression-Tracker/frontend#367