Added the case "Other" for the reference type

[marciuz]

(see e.g. https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0233831#references)

[Vitaliy-1]

Thanks!
Looking at the code, I think AbstractReference and classes that extend it needs refactoring, e.g., editors isn't a common property for all of the reference classes.
Regarding the other type of references, I'm not sure if we need it here in the long-term perspective. What I'm planning to support is journal article, book, chapter, conference, data, website, thesis, software, data, preprint, report and patent. I'm afraid other doesn't give much info about the reference structure. Do you think there could be types that aren't being covered by the list?

[Vitaliy-1]

Hi @marciuz,

If you'd like to make a contribution, can you make a PR for the last 2 commits separately from different branches? Say, branch metadata and move-examples?

[marciuz]

Hi @marciuz,

If you'd like to make a contribution, can you make a PR for the last 2 commits separately from different branches? Say, branch metadata and move-examples?

Yes of course, have you some suggestion about how to do it easily?

[Vitaliy-1]

E.g., create a new branch from the current master and cherry pick commit by hash to it.
Also, I propose to create a new issue for each feature.
Let's assume there is a new issue with a feature request that has number 20

git checkout -b i20_metadata
git cherry-pick 96c41011718adaf3507dc607175d8b0929a510be

You can check by git log if the commit is applied. Then you can make a PR as usual.
Sometimes you may need to update your fork to be aligned with remote master branch:

git checkout master
git pull upstream master
git push
git checkout <your-branch>
git rebase -i upstream/master
git push --force

This means you are switching to your master, fetching and merging it with your local master branch of the fork, pushing it to your fork, master branch, on the GitHub, switching to the branch on which you are working on a new feature, rebasing with your commits on top ( will have code from master branch with your new commits on top) and pushing it to your repo on the GitHub with history rewrite.
This operation may be required if, e.g., remote master branch contains new commits which would not allow merge changes from your branch.

[Vitaliy-1]

@marciuz,

FYI, I've started to work on integration of citeproc-php for references and Reference class is going to be completely rewritten to support different citation style formats.

[Vitaliy-1]

(I mean JATSParser\Back\Reference)

[marciuz]

Thanks, I will check it out. And when I find some time I will do the change as you suggested for the pull request... Best Il giorno gio 25 giu 2020 alle ore 11:08 Vitaliy <[email protected]> ha scritto:

…

(I mean JATSParser\Back\Reference) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKKXE2K2YMGWVCFAFNYR7LRYMH2RANCNFSM4NRCXOAQ> .

[Vitaliy-1]

Integration with citeproc-php is in the master branch now. If you are interested, can you test according to the example?
I've moved ii to the separate folder, as you suggested: https://github.com/Vitaliy-1/JATSParser/blob/master/examples/example.php
Let me know if it's unclear to you what citation styles are supported.