Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE - Implement display of number of answers/percentage in the widgets #171

Merged
merged 8 commits into from
Dec 11, 2024
Merged

FE - Implement display of number of answers/percentage in the widgets #171

merged 8 commits into from
Dec 11, 2024

Conversation

atrincas
Copy link
Collaborator

@atrincas atrincas commented Dec 3, 2024 •
edited
Loading

FE - Implement display of number of answers/percentage in the widgets

Overview

  • Calculation of response rate
  • Calculation of percentages without N/A values
  • Added additional chart colors
  • Updated unit tests

Designs

Figma

Testing instructions

Feature relevant tickets

SIRH-195

@atrincas atrincas added the front-end FE-related label Dec 3, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-growth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:02am

@atrincas atrincas changed the title FE - Implement display of number of answers/percentage in the widgets - DRAFT (Waiting for final design) FE - Implement display of number of answers/percentage in the widgets Dec 3, 2024
@atrincas atrincas marked this pull request as ready for review December 3, 2024 11:46
@alepefe
Copy link
Collaborator

alepefe commented Dec 3, 2024

@atrincas

  • Some client tests are failing
  • There icon with the response rate percentage might no be enough to let the user know what it is (I guess this is not up to us but up to the designers)
  • When I hover over the *icon with the response rate percentage, the cursor changes but the response rate tooltip does not always display on my google chrome browser
  • Javier sent us a message because the colors for each element in a pie chart are not being properly displayed.
    https://vizzuality.slack.com/archives/C06JJKMRBGS/p1733228483057379?thread_ts=1733153464.852109&cid=C06JJKMRBGS

@alepefe
Copy link
Collaborator

alepefe commented Dec 5, 2024

@atrincas I did not pay close attention to the frontend code but I everything is working now 😃

andresgnlez
andresgnlez approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@andresgnlez andresgnlez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, but overall, the PR LGTM

@atrincas atrincas merged commit 98c43c0 into dev Dec 11, 2024
5 checks passed
@atrincas atrincas deleted the SIRH-195-fe-implement-display-of-number-of-answers-percentage-in-the-widgets branch December 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alepefe alepefe alepefe approved these changes

@andresgnlez andresgnlez andresgnlez approved these changes

Assignees
No one assigned
Labels
front-end FE-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrincas @alepefe @andresgnlez