Feat: Implement Delete#56
Merged
Merged
Conversation
1- Update builders_delete template, following the same builder pattern, supporting Select and Omit 2- Update model_delete template declaring the Delete method on model delegates, the underlying executeDelete hook chain router, and runDelete database runner: - Simple delete with no select (defaults to returning all scalar fields) - Delete with scalar fields selection (returns requested scalar fields) - Delete with nested relations selection - Dialect native returning support via SupportsDeleteReturning, pre-querying both scalar fields and relations inside a transaction before deletion when relations are selected or when the dialect lacks RETURNING support using executeFindUnique under the hood as the full implementation is already in place, handling selection with relations and everything, separated from FindUnique to prevent hooks mixing up 3- Add DeleteQuery type and Delete extension hook signatures to the model_structs template 4- Add singular delete integration tests to delete_test.go covering basic deletion, scalar selection/omission, relation loading, 0-row sql.ErrNoRows error handling, and middleware hooks
VoidClancy
force-pushed
the
codegen-DELETE
branch
from
July 22, 2026 14:16
3c7595a to
4698c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Update builders_delete template, following the same builder pattern, supporting Select and Omit
2- Update model_delete template declaring the Delete method on model delegates, the underlying executeDelete hook chain router, and runDelete database runner:
using executeFindUnique under the hood as the full implementation is already in place, handling selection with relations and everything, separated from FindUnique to prevent hooks mixing up
3- Add DeleteQuery type and Delete extension hook signatures to the model_structs template
4- Add singular delete integration tests to delete_test.go covering basic deletion, scalar selection/omission, relation loading, 0-row sql.ErrNoRows error handling, and middleware hooks