Chore: update dialect support of RETURNING keyword to be per operation#59
Merged
Conversation
1- add SupportsInsert/Update/DeleteReturning instead of SupportsReturning to be per operation, in case a dialect does not support for all (PG and Sqlite does) 2- update usage of SupportsReturning to use the new defined per-operation field 3- update model_count and model_query templates to use d.client.query instead of calling prepare and stmt.QueryRowContext, the d.client.query is already a wrapper that calls that under the hood and allows logging, for consistency
…d of one unified field, run go mod tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- add SupportsInsert/Update/DeleteReturning instead of SupportsReturning to be per operation, in case a dialect does not support for all (PG and Sqlite does)
2- update usage of SupportsReturning to use the new defined per-operation field
3- update model_count and model_query templates to use d.client.query instead of calling prepare and stmt.QueryRowContext, the d.client.query is already a wrapper that calls that under the hood and allows logging, for consistency