Feat: start migration implementation - #1
Merged
Merged
Conversation
1- define a Dialect interface with GetSqlType(), GetSqlDefault(),QuoteIdent(), tho PG and Sqlite are kinda identical but for future extensibility(Mysql, sqlserver...etc) 2- define a makefile cuz i miss package.json scripts 3- define Providers consts in schema package to validate on parseand to reuse instead of literal strings in migrations 4- replace provider type in the schema with DbProvider, fix datasource resolution using ParseDbProvider() that errors 5- define typless constants which are PSL types to map into SQL and Go types and to use later in the migrations instead of string literals 6- define Postgres(and postgresql) and Sqlite Dialects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- define a Dialect interface with GetSqlType(), GetSqlDefault(), QuoteIdent(), tho PG and Sqlite are kinda identical but for future extensibility(Mysql, sqlserver...etc)
2- define a makefile cuz i miss package.json scripts
3- define Providers consts in schema package to validate on parseand to reuse instead of literal strings in migrations
4- replace provider type in the schema with DbProvider, fix datasource resolution using ParseDbProvider() that errors
5- define typless constants which are PSL types to map into SQL and Go types and to use later in the migrations instead of string literals
6- define Postgres(and postgresql) and Sqlite Dialects