Chore: refactor the create struct-based API to be function based for consistency with the reads - #25
Merged
Merged
Conversation
…consistency with the reads 1- define FieldAssignment (col+val) and RecordInput (slice of FieldAssignment) in header template 2- add .Set() on FieldT, UniqueFieldT, StringField, StringUniqueField in client template, field vars produce FieldAssignments 3- drop per-field SetFieldName() from model_predicate template, replaced by generic Set() 4- refactor create builders M,I,S,O to M,S,O, I param dead (and we killed him), since it's the same slice of FieldAssignment every time, now it lives on the struct itself 5- add per-model validateCreate() that iterates the assignment slice, checks required/string-safety/enum-range per field 6- add assignmentsToModelCreate converter, from []FieldAssignment to ModelCreate struct, falls naturally with the beforeCreate Hook that takes the same struct and allows mutuation 7- rebuild executeModelCreate to accept []FieldAssignment instead of ModelCreate, converts to struct internally for hooks, validates original assignments, reads mutated struct fields for cols/vals 8- add Record() helper on delegates, wraps []FieldAssignment into RecordInput for CreateMany 9- add trimPrefix to template FuncMap, strips (*) from GoType for type assertions on optional/defaulted fields 10- update integration tests to use the new function-based API 11- fix @default(autoincrement()) skip col when nil instead of leaving val slot empty, caught during test run 12- add doc comments on Queries delegate fields listing Create fields with types/constraints for hover DX 14- add enum doc comments on const values and namespace struct fields showing DB mapping on hover
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34685193 | Triggered | Generic Password | 85d0232 | integration/main.go | View secret |
| 34685192 | Triggered | Generic Password | 85d0232 | integration/main.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- define FieldAssignment (col+val) and RecordInput (slice of FieldAssignment) in header template
2- add .Set() on FieldT, UniqueFieldT, StringField, StringUniqueField in client template, field vars produce FieldAssignments
3- drop per-field SetFieldName() from model_predicate template, replaced by generic Set()
4- refactor create builders M,I,S,O to M,S,O, I param is dead (and we killed him), since it's the same slice of FieldAssignment every time, now it lives on the struct itself
5- add per-model validateCreate() that iterates the assignment slice, checks required/string-safety/enum-range per field
6- add assignmentsToModelCreate converter, from []FieldAssignment to ModelCreate struct, falls naturally with the beforeCreate Hook that takes the same struct and allows mutuation
7- rebuild executeModelCreate to accept []FieldAssignment instead of ModelCreate, converts to struct internally for hooks, validates original assignments, reads mutated struct fields for cols/vals
8- add Record() helper on delegates, wraps []FieldAssignment into RecordInput for CreateMany
9- add trimPrefix to template FuncMap, strips (*) from GoType for type assertions on optional/defaulted fields
10- update integration tests to use the new function-based API
11- fix @default(autoincrement()) skip col when nil instead of leaving val slot empty, caught during test run
12- add doc comments on Queries delegate fields listing Create fields with types/constraints for hover DX
14- add enum doc comments on const values and namespace struct fields showing DB mapping on hover