Feat: enforce compile-time model-safe query predicates - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Define PredicateOf[M] interface instead of Predicate, with a phantom(M) method to differentiate between models at compile-time
2- Define Predicate[M] and UniquePredicate[M] structs that house predicate data and implement PredicateOf[M]
3- Adapt Field[M, T], UniqueField[M, T], StringField[M], and StringUniqueField[M] to be parameterized by model type M, ensuring returned predicates are model-specific
4- Refactor logical operator helpers And[M], Or[M], and Not[M] to be generic over the model type parameter
5- Parameterize QueryParams[M] and update FindUniqueBuilder, FindFirstBuilder, and FindManyBuilder to accept model-scoped predicates
6- Update relation query generation helpers and loaders to work with the generic QueryParams[M] container