Promise rejects handled in AuthenticationManager fixes voryx#27

Volicon · Sep 28, 2014 · 8d71877 · 8d71877
1 parent ba46568
commit 8d71877
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/Thruway/Authentication/AuthenticationManager.php b/src/Thruway/Authentication/AuthenticationManager.php
@@ -41,6 +41,10 @@ public function onSessionStart($session, $transport)
             ->then(
                 function () {
                     $this->setReady(true);
+                },
+                function () {
+                    $this->setReady(false);
+                    $this->getManager()->error("registration of registerAuthMethod failed.");
                 }
             );
     }
@@ -200,6 +204,10 @@ function ($res) use ($session, $msg) {
                                 }
                             }
                         }
+                    },
+                    function () use ($session) {
+                        $this->getManager()->error("onhello rejected the promise");
+                        $session->abort("thruway.error.unknown");
                     }
                 );
                 $sentMessage = true;
@@ -287,6 +295,10 @@ function ($res) use ($session) {
                         } else {
                             $session->abort(new \stdClass(), "bad.login");
                         }
+                    },
+                    function () use ($session) {
+                        $this->getManager()->error("onauthenticate rejected the promise");
+                        $session->abort("thruway.error.unknown");
                     }
                 );
             }