Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual editor for working with data sources #211

Merged
merged 14 commits into from
Jan 31, 2024
Merged

Add visual editor for working with data sources #211

merged 14 commits into from
Jan 31, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Aug 28, 2023 •
edited
Loading

Resolves #210
Resolves #225

@asimonok asimonok self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (76cc42f) 92.85% compared to head (09fadf7) 96.16%.

Files Patch % Lines
src/components/EChartsEditor/EChartsEditor.tsx 85.71% 1 Missing ⚠️
src/utils/data-frame.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   92.85%   96.16%   +3.30%     
==========================================
  Files          16       35      +19     
  Lines         196      391     +195     
  Branches       24       47      +23     
==========================================
+ Hits          182      376     +194     
  Misses         12       12              
- Partials        2        3       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl mentioned this pull request Aug 28, 2023
Closed
@mikhail-vl mikhail-vl changed the title Feat/visual editor Add visual editor for working with data sources Aug 28, 2023
@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 28, 2023
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Aug 28, 2023
@mikhail-vl mikhail-vl self-requested a review August 29, 2023 10:08
@mikhail-vl
Copy link
Member

@asimonok Looks really promising!

Screenshot 2023-08-30 at 16 55 12

@asimonok asimonok marked this pull request as ready for review August 31, 2023 10:00
@asimonok asimonok mentioned this pull request Sep 8, 2023
Closed
This was referenced Nov 20, 2023
Closed
Closed
@mikhail-vl mikhail-vl linked an issue Nov 22, 2023 that may be closed by this pull request
data extraction helper feature #225
Closed
@yosiasz
Copy link

yosiasz commented Nov 22, 2023

woo hoo! great job !

mikhail-vl
mikhail-vl approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 82eaf0a into main Jan 31, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/visual-editor branch January 31, 2024 18:17
@mikhail-vl mikhail-vl mentioned this pull request Feb 1, 2024
Closed
@itsnull12 itsnull12 mentioned this pull request Feb 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.2.0
Development

Successfully merging this pull request may close these issues.

data extraction helper feature Add Panel options to parse the query data as Dataset
3 participants
@asimonok @mikhail-vl @yosiasz