Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint configuration and refactoring #237

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Conversation

mikhail-vl
Copy link
Member

  1. Update Config from Plugin Tools.
  2. Update GitHub Key to Access Policy.
  3. Update ESLint configuration.
  4. Use Collapse from components.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 31, 2024
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Jan 31, 2024
@mikhail-vl mikhail-vl requested a review from a team January 31, 2024 19:02
@mikhail-vl mikhail-vl self-assigned this Jan 31, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (82eaf0a) 96.16% compared to head (9725930) 95.44%.

❗ Current head 9725930 differs from pull request most recent head fe84f3d. Consider uploading reports for the commit fe84f3d to get more accurate results

Files Patch % Lines
src/components/EchartsPanel/EchartsPanel.tsx 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   96.16%   95.44%   -0.73%     
==========================================
  Files          35       32       -3     
  Lines         391      373      -18     
  Branches       47       44       -3     
==========================================
- Hits          376      356      -20     
  Misses         12       12              
- Partials        3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested a review from asimonok February 1, 2024 13:50
@asimonok asimonok removed the request for review from a team February 1, 2024 14:02
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 0cf454e into main Feb 1, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-workflow branch February 1, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants