Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make visual editor active by default #242

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves #238

@vitPinchuk vitPinchuk self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cf454e) 95.44% compared to head (ded67ba) 95.44%.
Report is 1 commits behind head on main.

❗ Current head ded67ba differs from pull request most recent head 5c6c390. Consider uploading reports for the commit 5c6c390 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          32       32           
  Lines         373      373           
  Branches       44       44           
=======================================
  Hits          356      356           
  Misses         12       12           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested a review from asimonok February 2, 2024 14:15
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review. Also provisioned dashboards were updated to enable code editor.

@asimonok asimonok requested a review from mikhail-vl February 2, 2024 15:17
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Feb 3, 2024
@mikhail-vl mikhail-vl added the enhancement New feature or request label Feb 3, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit b3b3b68 into main Feb 4, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/visual-editor-active-by-default branch February 4, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make visual editor active by default
3 participants