Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update echarts.volkovlabs.io to use visual editor and data sources #248

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Update echarts.volkovlabs.io to use visual editor and data sources #248

merged 12 commits into from
Feb 15, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #243

@vitPinchuk vitPinchuk requested a review from asimonok February 7, 2024 13:07
@vitPinchuk vitPinchuk self-assigned this Feb 7, 2024
asimonok
asimonok requested changes Feb 7, 2024
View reviewed changes
echarts.volkovlabs.io/bar.json Outdated Show resolved Hide resolved
asimonok
asimonok approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl February 7, 2024 13:39
@asimonok asimonok added the enhancement New feature or request label Feb 7, 2024
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Feb 8, 2024
@mikhail-vl
Copy link
Member

@vitPinchuk Good job, please continue:

  1. Update Editor Mode to Visual for updated panels.
  2. Convert more charts on Home and other dashboards to showcase as many use cases as possible.
  3. I updated Static Data Source properties to enable JavaScript Editor, it can be used to return values. Some charts has a lot of values and it's easier to return them using JavaScript.

@mikhail-vl mikhail-vl changed the title Migrate echarts.volkovlabs.io for visual editor and data sources Migrate echarts.volkovlabs.io to visual editor and data sources Feb 9, 2024
@mikhail-vl mikhail-vl changed the title Migrate echarts.volkovlabs.io to visual editor and data sources Migrate echarts.volkovlabs.io to use visual editor and data sources Feb 9, 2024
@mikhail-vl mikhail-vl changed the title Migrate echarts.volkovlabs.io to use visual editor and data sources Update echarts.volkovlabs.io to use visual editor and data sources Feb 15, 2024
mikhail-vl
mikhail-vl approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit cd6c2be into main Feb 15, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/migrate-echarts-for-visual-editor branch February 15, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.2.0
Development

Successfully merging this pull request may close these issues.

Migrate echarts.volkovlabs.io for visual editor and data sources
3 participants
@vitPinchuk @mikhail-vl @asimonok