Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Editor: Disallow to choose already selected fields #251

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Visual Editor: Disallow to choose already selected fields #251

merged 6 commits into from
Feb 9, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves #249

@vitPinchuk vitPinchuk requested a review from asimonok February 8, 2024 10:06
@vitPinchuk vitPinchuk self-assigned this Feb 8, 2024
@asimonok asimonok changed the title Incorrect Behavior Visual Editor Mode Visual Editor: Disallow to choose already selected fields Feb 8, 2024
@asimonok asimonok added the bug Something isn't working label Feb 8, 2024
asimonok
asimonok requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, please add tests for checking if user can't choose already selected fields

src/components/DatasetEditor/DatasetEditor.tsx Outdated Show resolved Hide resolved
asimonok
asimonok approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl February 8, 2024 11:55
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Feb 9, 2024
mikhail-vl
mikhail-vl approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 4700f7d into main Feb 9, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/delete-dataset-item branch February 9, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 5.2.0
Development

Successfully merging this pull request may close these issues.

Incorrect Behavior Visual Editor Mode
3 participants
@vitPinchuk @asimonok @mikhail-vl