Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto size code editor #263

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Mar 6, 2024

Resolves #262

@asimonok asimonok requested a review from mikhail-vl March 6, 2024 05:37
@asimonok asimonok self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (267e6a5) to head (802f866).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          34       34           
  Lines         423      423           
  Branches       72       72           
=======================================
  Hits          412      412           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 6, 2024
@mikhail-vl mikhail-vl added this to the Version 5.3.0 milestone Mar 6, 2024
@mikhail-vl mikhail-vl changed the title Add auto size code editor Update auto size code editor from fixed value Mar 6, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asimonok Should we add migration to remove height options from the panels?

@mikhail-vl mikhail-vl changed the title Update auto size code editor from fixed value Update auto size code editor from slider Mar 7, 2024
@mikhail-vl mikhail-vl changed the title Update auto size code editor from slider Update auto size code editor Mar 7, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit f6e5cde into main Mar 7, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/add-auto-size-code-editor branch March 7, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Code Editor to use Auto size instead of fixed value
2 participants