Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for non-context code parameters #276

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

asimonok
Copy link
Collaborator

Resolves #273

@asimonok asimonok requested a review from mikhail-vl March 25, 2024 13:07
@asimonok asimonok self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.12%. Comparing base (6903d13) to head (48de8d5).

❗ Current head 48de8d5 differs from pull request most recent head bdb6856. Consider uploading reports for the commit bdb6856 to get more accurate results

Files Patch % Lines
src/migration.ts 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   97.39%   97.12%   -0.28%     
==========================================
  Files          34       34              
  Lines         423      452      +29     
  Branches       61       85      +24     
==========================================
+ Hits          412      439      +27     
- Misses         11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 26, 2024
@mikhail-vl mikhail-vl added this to the Version 6.0.0 milestone Mar 26, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit a4aefa5 into main Mar 26, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/add-migration branch March 26, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migration logic for context parameters
2 participants