Skip to content

Conversation

OscarFava
Copy link
Contributor

What is this PR doing?

This PR is adding the Language selector to allow the user to change in real time which locale use.

How should this be manually tested?

Change to every language available and check that text is not overflowing components.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-208

Checklist

[X] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@OscarFava OscarFava added the update-screenshots Run update screenshots CI workflow label Oct 8, 2025
@OscarFava OscarFava closed this Oct 8, 2025
@OscarFava OscarFava reopened this Oct 8, 2025
…c.ts-snapshots/Landing-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
@OscarFava OscarFava removed the update-screenshots Run update screenshots CI workflow label Oct 8, 2025
@OscarFava OscarFava added the update-screenshots Run update screenshots CI workflow label Oct 8, 2025
@OscarFava OscarFava closed this Oct 8, 2025
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
@OscarFava OscarFava closed this Oct 10, 2025
@OscarFava OscarFava reopened this Oct 10, 2025
@OscarFava OscarFava closed this Oct 10, 2025
@OscarFava OscarFava reopened this Oct 10, 2025
behei-vonage
behei-vonage previously approved these changes Oct 10, 2025
Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@OscarFava OscarFava removed the update-screenshots Run update screenshots CI workflow label Oct 13, 2025
VZaphod
VZaphod previously approved these changes Oct 13, 2025
Copy link
Collaborator

@VZaphod VZaphod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnny-quesada-developer johnny-quesada-developer added the update-screenshots Run update screenshots CI workflow label Oct 13, 2025
@OscarFava OscarFava removed the update-screenshots Run update screenshots CI workflow label Oct 13, 2025
@OscarFava OscarFava dismissed stale reviews from VZaphod and behei-vonage via 2e27f8b October 14, 2025 09:06
@OscarFava OscarFava added update-screenshots Run update screenshots CI workflow and removed update-screenshots Run update screenshots CI workflow labels Oct 14, 2025
@OscarFava OscarFava closed this Oct 14, 2025
@OscarFava OscarFava reopened this Oct 14, 2025
Copy link

@OscarFava OscarFava closed this Oct 14, 2025
@OscarFava OscarFava deleted the ofava/vidsol-208-language-selector branch October 14, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants