Skip to content

Conversation

OscarFava
Copy link
Contributor

What is this PR doing?

Use global variables to change fontFamily and colors to make changes faster.

How should this be manually tested?

Change values and see if all components are updated accordingly.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-217

Checklist

[X] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

Copy link

@OscarFava OscarFava added the update-screenshots Run update screenshots CI workflow label Oct 13, 2025
OscarFava and others added 7 commits October 13, 2025 11:43
…c.ts-snapshots/Landing-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
@OscarFava OscarFava removed the update-screenshots Run update screenshots CI workflow label Oct 13, 2025
…c.ts-snapshots/Landing-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, it's great to see we're heading to a more consistent approach with theming 🙏

@behei-vonage behei-vonage reopened this Oct 13, 2025
@behei-vonage
Copy link
Contributor

fyi, @OscarFava, some failing unit tests ⏫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants