Double_GEAR_ratio_Z #1052
Merged
Double_GEAR_ratio_Z #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirpy2605
reviewed
Jul 12, 2024
| mod_version: 1 | ||
| discord_username: ZZP8202 | ||
| cad: | ||
| - 3D/Double_GEAR_ratio_Z_belt_assembly_with_Spherical_Bearing_connection |
There was a problem hiding this comment.
The file name in this file "Double_GEAR_ratio_Z_belt_assembly_with_Spherical_Bearing_connection" is missing the .STEP at the end to the actual file name
There was a problem hiding this comment.
Could you resize this pic as it's over 2MB in size. For example, I've attached a resized one that is 10% of the file size
chirpy2605
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Could you please add a section that explains exactly how to assemble this Modification on the printer using text and pictures/images to details how it goes together.
|
I have resize the photo , add assemble instructions with gif image, and edit the '.metadata.yml' file. |
chirpy2605
suggested changes
Jul 14, 2024
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
The README.md is referencing "Images/ezgif.com-resize.gif" but that file does not exist
| - Images/CAD_front_view.png | ||
| - Images/CAD_side_view.png | ||
| - Images/Photo.jpg | ||
| -Other/Assemble_Instructions/Pulley_Holder.gif |
There was a problem hiding this comment.
There are some formatting errors in the YAML file. "The Other:" section should be first and then the subsequent entries need a space after the "-" in "-/Other/..."
Like so:
Other:
- Other/Assemble_Instructions/Pulley_Holder.gif
- Other/Assemble_Instructions/Z_Bearing_Block_Bottom_With_Pulley.gif
- Other/Assemble_Instructions/BOM/Pulley_Holder_X4_BOM.png
- Other/Assemble_Instructions/BOM/Z_Bearing_Block_Bottom_With_Pulley_BOM.png
- Other/Assemble_Instructions/BOM/Pulley_Holder_X4_BOM.pdf
- Other/Assemble_Instructions/BOM/Z_Bearing_Block_Bottom_With_Pulley_BOM.pdf
|
sorry for mistake, I have fix it as your marked. |
chirpy2605
approved these changes
Jul 14, 2024
|
Hey @zzp8202, Thanks for submitting, very cool mod! Upon my review I've noticed that:
Other than that it looks good to me and once the two issues mentioned above has been dealt with i'll happily approve this mod. Thanks! |
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅Readme generator
STL corruption checker
STL rotation checker
Markdown link checker
File checker
WARNING:
|
| Item | Result | Reason |
|---|---|---|
| ZZP8202/Double_GEAR_ratio_Z/3D/Double_GEAR_ratio_Z_belt_assembly_with_Spherical_Bearing_connection.STEP | This file is larger than 2 MB! | |
| ZZP8202/Double_GEAR_ratio_Z/Other/Assemble_Instructions/Z_Bearing_Block_Bottom_With_Pulley.gif | This file is larger than 2 MB! | |
| ZZP8202/Double_GEAR_ratio_Z/Other/Assemble_Instructions/Pulley_Holder.gif | This file is larger than 2 MB! |
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which mods are added by this PR?
One
How was it tested?
Test by myself.
Any background context you want to provide?
Enabling the Voron 2.4 Gantry to Defy Gravity
Screenshots (if appropriate)
my mod adheres to these rules.
license