-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'N:' command #2726
base: master
Are you sure you want to change the base?
Support 'N:' command #2726
Conversation
{ | ||
Create(""); | ||
_vimBuffer.Process("1"); | ||
_vimBuffer.Process(":"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines can be combined into _vimBuffer.Process("1:")
{ | ||
Create(""); | ||
_vimBuffer.Process("2"); | ||
_vimBuffer.Process(":"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines can be combined into _vimBuffer.Process("2:")
Src/VimCore/CoreInterfaces.fs
Outdated
@@ -2736,6 +2736,32 @@ with | |||
| Some transaction -> transaction.Complete() | |||
| Option.None -> () | |||
|
|||
[<RequireQualifiedAccess>] | |||
type SwitchCommandModeArgument = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create a new type here instead of just expanding the values of ModeArgument
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a correction, but I am not confident.
Because this PR is not urgent,
Please give priority to the release work of 2.8.0.
Is the following change better? |
Closes #2725